Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the 'Prefix' Check for swift:module Metadata #3529

Open
InsertCreativityHere opened this issue Feb 10, 2025 · 0 comments
Open

Loosen the 'Prefix' Check for swift:module Metadata #3529

InsertCreativityHere opened this issue Feb 10, 2025 · 0 comments

Comments

@InsertCreativityHere
Copy link
Member

The swift:module is of the form: swift:module:<Module>:<Prefix>, so it accepts two positional arguments.
If this metadata is applied to the same module within the same file (ie. you've re-opened it in the same file), we enforce that both the <Module> and <Prefix> parts are identical.

This is overzealous.
The modules do need to match, since Swift only supports having 1 module per file, but there's no reason for the prefixes to match necessarily.

We should remove this extra checking of the prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant