Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: httpx.ParseJsonBody error when request has []byte field #4450 #4471

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

studyzy
Copy link
Contributor

@studyzy studyzy commented Nov 26, 2024

--bug=4450

@kevwan
Copy link
Contributor

kevwan commented Nov 26, 2024

How can we know it's base64 encoded?

@studyzy
Copy link
Contributor Author

studyzy commented Nov 27, 2024

How can we know it's base64 encoded?

Since golang official json.Marshal/json.Unmarshal use base64 encoding to process []byte.

@kevwan kevwan force-pushed the fix/httpxParseJsonBody branch from d7b78d6 to 6394a2d Compare January 22, 2025 13:26
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.51%. Comparing base (8690859) to head (6394a2d).
Report is 227 commits behind head on master.

Files with missing lines Patch % Lines
core/mapping/unmarshaler.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
core/mapping/unmarshaler.go 95.08% <57.14%> (-1.40%) ⬇️

... and 7 files with indirect coverage changes

@kevwan kevwan merged commit cbcacf3 into zeromicro:master Jan 22, 2025
5 of 6 checks passed
@kevwan kevwan linked an issue Jan 22, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: httpx.ParseJsonBody don't support bytes field
2 participants