Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with HuggingFace #6

Open
wjbmattingly opened this issue Sep 18, 2024 · 5 comments
Open

Working with HuggingFace #6

wjbmattingly opened this issue Sep 18, 2024 · 5 comments

Comments

@wjbmattingly
Copy link

Hi, thanks for this wonderful script! This was really helpful for me to get a fine-tuning pipeline working. I'd like to share my work, but wanted to share it here first and make sure proper credit was given. This is the repo below:

https://github.com/wjbmattingly/qwen2-vl-finetune-huggingface

As you can see, I've made substantial modifications and added an app for fine-tuning. Would you be interested in a PR that provides the training script for HF here? I can modify it to align with your workflow.

@zhangfaen
Copy link
Owner

Hi William,
I am very happy that my repo is helpful. Your PR will be a great addtional value to this repo, looking forward to that.

@wjbmattingly
Copy link
Author

Thanks! I didn't see your license on this code. Is it okay with you if I share this work? And do you like the way I gave your work credit? If not, please let me know how I can expand it.

@zhangfaen
Copy link
Owner

Hi William,
I added a MIT LICENSE file in my repo. I just had a look at your repo, thank you for mentioning my repo in the README of your repo. That way is OK.

@wjbmattingly
Copy link
Author

Thanks for the quick response! I'll be in touch about a PR soon! =)

@zhangfaen
Copy link
Owner

Cool, looking forward to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants