Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders Feature #80

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions JenkinsTray/BusinessComponents/ConfigurationService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -301,5 +301,14 @@ public void SetBalloonNotifications(bool value)
SaveConfiguration();
}
}

public void SetShowFolders(bool value)
{
if (GeneralSettings.ShowFolders != value)
{
GeneralSettings.ShowFolders = value;
SaveConfiguration();
}
}
}
}
14 changes: 10 additions & 4 deletions JenkinsTray/BusinessComponents/JenkinsService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ public JenkinsService()

public ClaimService ClaimService { get; set; }

public ConfigurationService ConfigurationService { get; set; }

public IList<Project> LoadProjects(Server server)
{
var url = NetUtils.ConcatUrls(server.Url, "/api/xml?tree=jobs[name,url,color]");
Expand All @@ -59,29 +61,33 @@ public IList<Project> LoadProjects(Server server)
return projects;
}

public List<Project> GetProjects(XmlNodeList jobElements, Server server)
public List<Project> GetProjects(XmlNodeList jobElements, Server server, string folder = "")
{
var projects = new List<Project>();

foreach (XmlNode jobElement in jobElements)
{
var projectName = jobElement.SelectSingleNode("name").InnerText;
var projectUrl = jobElement.SelectSingleNode("url").InnerText;
var projectColor = jobElement.SelectSingleNode("color");
// If the job is a folder we need to recursively get the jobs within.
if (jobElement.SelectSingleNode("color") == null)
if (projectColor == null) //folders do not have a color node
{
var url = NetUtils.ConcatUrls(projectUrl, "/api/xml?tree=jobs[name,url,color]");
var xmlStr = DownloadString(server.Credentials, url, false, server.IgnoreUntrustedCertificate);
var xml = new XmlDocument();
xml.LoadXml(xmlStr);
var nodes = xml.SelectNodes("/folder/job");
projects.AddRange(GetProjects(nodes, server));
projects.AddRange(GetProjects(nodes, server, projectName));
}
else
{
var project = new Project();
project.Server = server;
if (!string.IsNullOrEmpty(folder))
{
project.Folder = folder;
}
project.Name = projectName;
project.Url = projectUrl;

Expand Down
3 changes: 3 additions & 0 deletions JenkinsTray/Entities/GeneralSettings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ public GeneralSettings()
[JsonProperty("checkForUpdates")]
public bool CheckForUpdates { get; set; }

[JsonProperty("showFolders")]
public bool ShowFolders { get; set; }

public ApplicationUpdateService ApplicationUpdateService { get; set; }
}
}
8 changes: 7 additions & 1 deletion JenkinsTray/Entities/Project.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ public Project()

public Server Server { get; set; }

[JsonProperty("folder")]
public string Folder { get; set; }

[JsonProperty("name")]
public string Name { get; set; }

Expand Down Expand Up @@ -128,8 +131,11 @@ public override bool Equals(object obj)
var other = obj as Project;
if (other == null)
return false;
if (Server == null)
return false;
return other.Server.Equals(Server)
&& other.Name == Name;
&& other.Name == Name
&& other.Folder == Folder;
}

public override string ToString()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public Configuration LoadConfiguration()
generalSettings.UpdateMainWindowIcon = propertiesFile.GetBoolValue("general.UpdateMainWindowIcon", true);
generalSettings.IntegrateWithClaimPlugin = propertiesFile.GetBoolValue("general.IntegrateWithClaimPlugin",
true);
generalSettings.ShowFolders = propertiesFile.GetBoolValue("general.ShowFolders", false);

var res = new Configuration
{
Expand Down
18 changes: 16 additions & 2 deletions JenkinsTray/UI/Controls/ProjectListControl.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 23 additions & 2 deletions JenkinsTray/UI/Controls/ProjectListControl.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public partial class ProjectListControl : XtraUserControl
{
private List<Project> projectsDataSource;
private Server server;

public ProjectListControl()
{
InitializeComponent();
Expand All @@ -27,11 +27,18 @@ public ProjectListControl()

public void Initialize()
{
SetFoldersVisibility(ConfigurationService.GeneralSettings.ShowFolders);
ConfigurationService.ConfigurationUpdated += configurationService_ConfigurationUpdated;
}

public void UpdateProjectList(Server server)
{
this.server = server;
RefreshList();
}

private void RefreshList()
{
#if SYNCRHONOUS
List<Project> dataSource = new List<Project>();

Expand All @@ -55,7 +62,7 @@ public void UpdateProjectList(Server server)
Enabled = false;
var status = string.Format(JenkinsTrayResources.LoadingProjects_FormatString, server.Url);
Controller.SetStatus(status, true);

// run the process in background
var process = new Process("Loading project " + server.Url);
IList<Project> projects = null;
Expand Down Expand Up @@ -94,6 +101,20 @@ private void SetProjectsDataSource(List<Project> dataSource)
projectsGridControl.DataSource = projectsDataSource;
}

private void configurationService_ConfigurationUpdated()
{
if (folderNameGridColumn.Visible != ConfigurationService.GeneralSettings.ShowFolders)
{
SetFoldersVisibility(ConfigurationService.GeneralSettings.ShowFolders);
RefreshList();
}
}

private void SetFoldersVisibility(bool showFolders)
{
folderNameGridColumn.Visible = showFolders;
}

private void projectsGridView_CustomUnboundColumnData(object sender, CustomColumnDataEventArgs e)
{
if (e.IsGetData)
Expand Down
31 changes: 25 additions & 6 deletions JenkinsTray/UI/MainForm.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions JenkinsTray/UI/MainForm.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,15 @@ protected override void OnLoad(EventArgs e)
base.OnLoad(e);
Initialize();
UpdateClaimPluginIntegration();
SetFoldersVisibility();
LoadIcons();
LoadProjects();
}

private void configurationService_ConfigurationUpdated()
{
UpdateClaimPluginIntegration();
SetFoldersVisibility();
LoadProjects();
if (ConfigurationService.GeneralSettings.UpdateMainWindowIcon == false)
ResetIcon();
Expand Down Expand Up @@ -610,6 +612,11 @@ private void UpdateClaimPluginIntegration()
}
}

private void SetFoldersVisibility()
{
folderGridColumn.Visible = ConfigurationService.GeneralSettings.ShowFolders;
}

private void acknowledgeProjectMenuItem_Click(object sender, EventArgs e)
{
var menuItem = sender as ToolStripMenuItem;
Expand Down Expand Up @@ -650,6 +657,11 @@ public string Server
get { return Project.Server.DisplayText; }
}

public string Folder
{
get { return Project.Folder; }
}

public string Name
{
get { return ShowDisplayname && string.IsNullOrEmpty(Project.DisplayName) ? Project.Name : Project.DisplayName; }
Expand Down
Loading