Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark pkg.strings for deprecation #679

Closed
1 of 2 tasks
isegura-eos-eng opened this issue Nov 13, 2024 · 1 comment
Closed
1 of 2 tasks

Mark pkg.strings for deprecation #679

isegura-eos-eng opened this issue Nov 13, 2024 · 1 comment

Comments

@isegura-eos-eng
Copy link
Contributor

Preflight Checklist

  • I could not find a solution in the existing issues, docs, nor discussions
  • I have joined the ZITADEL chat

Describe your problem

Since go1.21 there exist a stdlib slices package. This includes the functionality that this project pkg/strings, which is the strings.Contains function. The homonymous slices function works also for strings.

Describe your ideal solution

I propose to mark this function for deprecation and remove any reference from the project code. This way package clients can still use this for v3.

Version

3.33.1

Environment

Self-hosted

Additional Context

I'm gonna submit the PR, we already discussed this briefly in: #660 (comment)

@hifabienne
Copy link
Member

I think we can close this issue as the pr is already mergedd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants