You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since go1.21 there exist a stdlib slices package. This includes the functionality that this project pkg/strings, which is the strings.Contains function. The homonymous slices function works also for strings.
Describe your ideal solution
I propose to mark this function for deprecation and remove any reference from the project code. This way package clients can still use this for v3.
Version
3.33.1
Environment
Self-hosted
Additional Context
I'm gonna submit the PR, we already discussed this briefly in: #660 (comment)
The text was updated successfully, but these errors were encountered:
Preflight Checklist
Describe your problem
Since go1.21 there exist a stdlib
slices
package. This includes the functionality that this projectpkg/strings
, which is thestrings.Contains
function. The homonymousslices
function works also for strings.Describe your ideal solution
I propose to mark this function for deprecation and remove any reference from the project code. This way package clients can still use this for v3.
Version
3.33.1
Environment
Self-hosted
Additional Context
I'm gonna submit the PR, we already discussed this briefly in: #660 (comment)
The text was updated successfully, but these errors were encountered: