Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'skip login success page' option for native app redirect settings #181

Open
2 tasks done
dmytrum opened this issue May 29, 2024 · 2 comments
Open
2 tasks done
Labels

Comments

@dmytrum
Copy link

dmytrum commented May 29, 2024

Preflight Checklist

  • I could not find a solution in the documentation, the existing issues or discussions
  • I have joined the ZITADEL chat

Version

1.2.0

ZITADEL Version

No response

Describe the problem caused by this bug

When creating native app, in redirect settings there is an option 'Skip Login Success Page', but it looks like it missed in tf provider.

To reproduce

  1. Define zitadel_application_oidc resource in terraform
  2. skip_login_success_page is missing

Screenshots

image

Expected behavior

No response

Relevant Configuration

No response

Additional Context

No response

@dmytrum dmytrum added the bug Something isn't working label May 29, 2024
@hifabienne hifabienne added improvement and removed bug Something isn't working labels May 31, 2024
@hifabienne
Copy link
Member

Hi @dmytrum
Thanks for adding this.
I do not really consider this as a bug, as each attribute has currently to be added manually to the terraform provider when something changes in the api, i see it as an improvement.

I will put it to the small issues/bug fixing state.
Meanwhile, if you're interested in implementing it yourself, we also welcome pull requests.

@hifabienne hifabienne moved this to 🐛 Bugs/Small Issues in Product Management May 31, 2024
@hifabienne hifabienne added the good first issue Good for newcomers label May 31, 2024
@dmytrum
Copy link
Author

dmytrum commented Jun 3, 2024

image

@hifabienne here is another problem I discovered - as you can see 'Skip Login Success Page' is checked. When I adding with terraform 'Redirect URIs' - 'Skip Login Success Page' returns back to unchecked (default state)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🐛 Bugs/Small Issues
Development

No branches or pull requests

2 participants