Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDP register #35

Merged
merged 35 commits into from
Aug 3, 2023
Merged

IDP register #35

merged 35 commits into from
Aug 3, 2023

Conversation

peintnermax
Copy link
Member

@peintnermax peintnermax commented Jul 26, 2023 •
edited
Loading

Adds a page /register/idp which is used to register uses via Identity provider

Closes #14

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Jest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

@vercel
Copy link

vercel bot commented Jul 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2023 8:03am

@peintnermax peintnermax marked this pull request as ready for review August 2, 2023 11:15
eliobischof
eliobischof reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the IDPs dynamically shown based on configured providers in ZITADEL?

apps/login/app/(login)/register/idp/[provider]/success/page.tsx Outdated Show resolved Hide resolved
apps/login/app/(login)/register/idp/[provider]/success/page.tsx Show resolved Hide resolved
packages/zitadel-react/src/components/ZitadelReactProvider.tsx Show resolved Hide resolved
apps/login/ui/SignInWithIDP.tsx Show resolved Hide resolved
@eliobischof
Copy link
Member

the integration tests fail

@peintnermax
Copy link
Member Author

the integration tests fail

seems we have some flakiness in there.. It worked now on rerun

@peintnermax peintnermax merged commit b330367 into main Aug 3, 2023
4 checks passed
@peintnermax peintnermax deleted the idp-register branch August 3, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hifabienne hifabienne hifabienne left review comments

@fforootd fforootd fforootd left review comments

@eliobischof eliobischof eliobischof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login: Register User with IDP
4 participants
@peintnermax @eliobischof @fforootd @hifabienne