Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove Setup and Keccak (Setup) example #62

Open
oskarth opened this issue Jan 29, 2024 · 3 comments
Open

Cleanup: Remove Setup and Keccak (Setup) example #62

oskarth opened this issue Jan 29, 2024 · 3 comments

Comments

@oskarth
Copy link
Collaborator

oskarth commented Jan 29, 2024

It doesn't make much sense to do trusted setup in a mobile app, so we can remove this.

We also want to remove this API usage in other parts of the code.

@oskarth
Copy link
Collaborator Author

oskarth commented Feb 23, 2024

A bunch of this was removed from recent PR #75 by @vivianjeng

Maybe some left-overs for Setup, not sure?

@vivianjeng
Copy link
Collaborator

They are all replaced by proving with arkzkey and wasm
The issue can be closed. 🙏🏻

@oskarth
Copy link
Collaborator Author

oskarth commented Mar 5, 2024

This is a separate issue from OP now I realize, but we probably want to make this cleaner: https://github.com/oskarth/mopro/blob/main/mopro-ffi/src/lib.rs right now two generate_proof functions and it is a bit confusing which to use.

https://github.com/oskarth/mopro/blob/main/mopro-ffi/src/lib.rshttps://github.com/oskarth/mopro/blob/main/mopro-ffi/src/lib.rs 3 initialize functions, two generate proof, two verify proof and two interfaces :D

We'd want to simplify this a bit, and if there are options (like dylib, arkzkey, path etc) it should be clear. I believe this is also what @Meyanis95 referred to earlier in chat.


On OP issue we still have https://github.com/oskarth/mopro/blob/main/mopro-ios/MoproKit/Example/MoproKit/KeccakSetupViewController.swift with Setup in it. I think we should make this part more explicit, and maybe even remove some examples (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants