Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zman wont parse dates before 4 Shvat, 3860 #37

Open
pintend opened this issue Sep 3, 2024 · 0 comments · May be fixed by #38
Open

Zman wont parse dates before 4 Shvat, 3860 #37

pintend opened this issue Sep 3, 2024 · 0 comments · May be fixed by #38

Comments

@pintend
Copy link

pintend commented Sep 3, 2024

php supports as low as 18 Teives, 3761 which is Jan 1 0001 CE

Zman::createFromJewishDate(3860, 5, 4)->jewishYear === 3860
This should NOT be true:
Zman::createFromJewishDate(3860, 5, 3)->jewishYear === 5760
@pintend pintend linked a pull request Sep 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support for as low as 18 Teives, 3761 pintend/zman
1 participant
@pintend