Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio GLITCHES #571

Open
ClarkFieseln opened this issue Dec 30, 2024 · 11 comments
Open

Audio GLITCHES #571

ClarkFieseln opened this issue Dec 30, 2024 · 11 comments
Labels

Comments

@ClarkFieseln
Copy link

Describe the bug
The audio signal shows many glitches

To Reproduce
Record audio on receiver side (e.g. connecting speaker in USB sound card to mic in a PC running Audacity)

Expected behavior
The audio signal has no glitches

Your system information:

  • TRIfA Version: 1.0.231
  • App from Google-Play : TRIfA
  • Android OS Version: Android 9
  • Device: HUAWEI P smart

Add screenshots, if possible

Additional context
The output volume seems to be very low!
I tried several different combinations of settings without success (audio buffer, frame size, sampling rate, UDP active, force UDP mode).

Some years ago I solved a similar problem by opening the audio interface with CALL_MODE instead of COMMUNICATION_MODE

@zoff99
Copy link
Owner

zoff99 commented Dec 30, 2024

first let me say that google play is no longer the main distrubution channel for this app.
please install the latest version from https://github.com/zoff99/ToxAndroidRefImpl/releases
it is signed with the same key as the google play version.

@zoff99
Copy link
Owner

zoff99 commented Dec 30, 2024

which tox client is the receiver side using? and are you calling audio only or also video?
if possible give as much details as you can.

@ClarkFieseln
Copy link
Author

both smartphones are exactly as described above, and both see the glitches.
This is an "audio call" from TRIfA to TRIfA.
I noticed this behavior some years ago already and I still assume that the "call mode" may solve the problem.

@zoff99
Copy link
Owner

zoff99 commented Dec 30, 2024

did you change it in the source code and compiled yourself to fix it, or what do you mean by "Some years ago I solved a similar problem" ? TRIfA uses native code for audio recording and playback via OpenSLES

@ClarkFieseln
Copy link
Author

ClarkFieseln commented Dec 30, 2024

it was my own app, but the effect was exactly the same
I saw many comments all over the internet claiming that the audio quality is much better in call mode

@zoff99
Copy link
Owner

zoff99 commented Dec 30, 2024

audio mode is tricky stuff on android. i ran into lots of issues depending on the device.
what sort of audio glitches do you have? can you give more details?
is it "just" bad quality audio or choppy (parts missing all the time), or sounding like robot?

i can let CI build a debug version with COMMUNICATION_MODE, could you test that version?

@ClarkFieseln
Copy link
Author

I can repeat the tests tomorrow and upload the file(s) with the glitches, but sorry, I cannot do much more than that.
Maybe you could just add a configuration option to allow selecting the "call mode" on own risk, as an experimental feature. That would be great.

@zoff99
Copy link
Owner

zoff99 commented Dec 30, 2024

can you install and test with the nightly version? it can be installed alongside the regular trifa

@ClarkFieseln
Copy link
Author

you mean with the new experimental feature? Sure, I can do that.

@zoff99
Copy link
Owner

zoff99 commented Dec 30, 2024

https://github.com/zoff99/ToxAndroidRefImpl/releases/download/nightly/TRIfA-nightly.apk
this has it changed:
7ff1a9c

it has also turned logging on.
if you can still "repeat the tests tomorrow and upload the file(s) with the glitches" that would be super.

@ClarkFieseln
Copy link
Author

unfortunately the same behavior
attached you find 2 example files with some glitches
sweep_test_with_glitches.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants