Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divergence in transaction signature between paper and current implementation #656

Open
dapi opened this issue Dec 27, 2018 · 4 comments
Open
Labels
bug Something isn't working scope

Comments

@dapi
Copy link
Contributor

dapi commented Dec 27, 2018

Paper recommend to use hex amount:

screenshot 2018-12-27 at 20 36 59

While implementation uses integer:

https://github.com/zold-io/zold/blob/master/lib/zold/signature.rb#L68

IMHO paper way is better

@0crat
Copy link
Collaborator

0crat commented Dec 27, 2018

@yegor256/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Dec 27, 2018

@dapi/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@yegor256 yegor256 added the bug Something isn't working label May 20, 2019
@0crat 0crat added the scope label May 20, 2019
@0crat
Copy link
Collaborator

0crat commented May 20, 2019

Job #656 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented May 20, 2019

Bug was reported, see §29: +15 point(s) just awarded to @dapi/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope
Projects
None yet
Development

No branches or pull requests

3 participants