Updates the translation of FAQ into Finnish #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
added
the
A-Translation
|
Closed
matsduf
added
the
V-Patch
samisalmensuo
approved these changes
May 22, 2023
samisalmensuo
previously approved these changes
May 22, 2023
|
Hi,
3. The document links to Internetstiftelsen (https://internetstiftelsen.se/). In Non-Swedish contexts we usually use The Swedish Internet Foundation (https://internetstiftelsen.se/en/). What is best in a Finnish context?
That does not need to be Finnish, I think that https://internetstiftelsen.se/en/ Is OK.
4. I find a link [Määritetyt testitapaukset] without a URL. What should the URL be?
I think that this is the best:
https://github.com/zonemaster/zonemaster/tree/master/docs/specifications/tests#list-of-defined-test-cases
Br,
- Sami
…-----Original Message-----
From: Mats Dufberg ***@***.***>
Sent: keskiviikko 17. toukokuuta 2023 0.17
To: zonemaster/zonemaster-gui ***@***.***>
Cc: Salmensuo Sami ***@***.***>; Mention ***@***.***>
Subject: Re: [zonemaster/zonemaster-gui] Updates the translation of FAQ into Finnish (PR #419)
@samisalmensuo <https://github.com/samisalmensuo> :
1. Find the rendered Finnish version <https://github.com/zonemaster/zonemaster-gui/blob/d68824938494de8e1676ffcf26640ca399ba6a04/docs/FAQ/gui-faq-fi.md> of this update
2. Please review against the current English version <https://github.com/zonemaster/zonemaster-gui/blob/develop/docs/FAQ/gui-faq-en.md>
3. The document links to Internetstiftelsen (https://internetstiftelsen.se/). In Non-Swedish contexts we usually use The Swedish Internet Foundation (https://internetstiftelsen.se/en/). What is best in a Finnish context?
4. I find a link [Määritetyt testitapaukset] without a URL. What should the URL be?
—
Reply to this email directly, view it on GitHub <#419 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK2SM6YHJGFSXVAP5MBXPPTXGPVE3ANCNFSM6AAAAAAYEGCI74> .
You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AK2SM66ZHICYAZHL4CS3DALXGPVE3A5CNFSM6AAAAAAYEGCI76WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS4NC7CW.gif> Message ID: ***@***.***>
|
|
@samisalmensuo, your update included (plus some minor edits). Please review. |
samisalmensuo
approved these changes
May 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR provides an updated translation of the FAQ in Finnish provided by @samisalmensuo.
Context
Resolves #358.
How to test this PR
Review the text or formal aspects of the FAQ.