Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update in Configuration.md and Installation.md needed #374

Closed
matsduf opened this issue Dec 13, 2022 · 1 comment · Fixed by #375
Closed

Update in Configuration.md and Installation.md needed #374

matsduf opened this issue Dec 13, 2022 · 1 comment · Fixed by #375
Labels
T-Bug Type: Bug in software or error in test case description
Milestone
v2022.2

Comments

@matsduf
Copy link
Contributor

matsduf commented Dec 13, 2022 •
edited by tgreenx
Loading

Quoted from #332 (comment):

However the documentation file needs an update, as the configuration is now per language (e.g. dist/en/assets) instead of global (i.e. dist/assets/) (due to #349). A fix for that may also be desired.

Quoted from #331 (comment):

A small update to the documentation is needed though. I'll add this to #374.
- in 3. : path of file is missing language subdirectory, due to #349 (/var/www/html/zonemaster-web-gui/dist/assets/app.config.json instead of /var/www/html/zonemaster-web-gui/dist/*/assets/app.config.json)
- typo in NOTE: configurartion instead of configuration
@matsduf matsduf added the T-Bug Type: Bug in software or error in test case description label Dec 13, 2022
@matsduf matsduf added this to the v2023.1 milestone Dec 13, 2022
@matsduf matsduf mentioned this issue Dec 13, 2022
Merged
@tgreenx tgreenx mentioned this issue Dec 13, 2022
Merged
@tgreenx tgreenx changed the title Update in Configuration.md needed Update in Configuration.md and Installation.md needed Dec 13, 2022
@hannaeko hannaeko mentioned this issue Dec 13, 2022
Merged
@tgreenx tgreenx modified the milestones: v2023.1, v2022.2 Dec 13, 2022
@tgreenx tgreenx linked a pull request Dec 13, 2022 that will close this issue
Deduplicate the assets directory #375
Merged
@matsduf
Copy link
Contributor Author

matsduf commented Dec 19, 2022

Resolved by #375

@matsduf matsduf closed this as completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Bug Type: Bug in software or error in test case description
Projects
None yet
Milestone
v2022.2
Development

Successfully merging a pull request may close this issue.

Deduplicate the assets directory hannaeko/zonemaster-gui
2 participants
@matsduf @tgreenx