Update gui api #1198
Merged
Update gui api #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannaeko
added
A-Documentation
hannaeko
requested review from
mattias-p,
matsduf,
a user,
tgreenx and
marc-vanderwal
ghost
previously approved these changes
Aug 21, 2023
matsduf
requested changes
Aug 21, 2023
docs/public/using/gui/api.md
Outdated
| The GUI will rewrite `<lang>/test/<test-id>` to `<lang>/result/<test-id>` | ||
| before the result is displayed. | ||
|
|
||
| The GUI will redirect from `<path>` to `<lang>/<path>` automatically. |
There was a problem hiding this comment.
It should be specified how <lang> is selected for this case.
There was a problem hiding this comment.
I have clarified this section a bit more.
matsduf
reviewed
Aug 30, 2023
docs/public/using/gui/api.md
Outdated
Comment on lines
28
to
30
| The GUI will redirect from `<path>` to `<lang>/<path>` automatically using the | ||
| user browser language, defaulting to the default language defined in the | ||
| reverse proxy configuration. |
There was a problem hiding this comment.
Does this mean
The GUI will redirect from `<path>` to `<lang>/<path>` automatically using the
user browser language, if that is defined for the installation. Else using the default
language defined in the reverse proxy configuration.
There was a problem hiding this comment.
Could you spell that out to make it easier to read?
matsduf
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update the documentation following the introduction of language in URL.
Context
zonemaster/zonemaster-gui#377
Changes
Add in all paths.
How to test this PR
N/A