Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot lookup data for IDN domain #426

Closed
ghost opened this issue May 31, 2023 · 2 comments
Closed

Cannot lookup data for IDN domain #426

ghost opened this issue May 31, 2023 · 2 comments
Labels
T-Bug Type: Bug in software or error in test case description
Milestone

Comments

@ghost
Copy link

ghost commented May 31, 2023

Bug encountered while testing for v2023.1 (see #410 (comment)).

Step to reproduce:

  1. populate the input with an IDN domain such as réussir-en.fr
  2. open the options
  3. click on "Fetch NS from parent zone"
  4. see the popup "No data found for the zone."

Expected behavior:
Data should be retrieved for the given zone.

I digged a little bit into this, and it looks like the Backend does not convert the input domain in lookup_delegation_data.

Should the client send a converted domain or should we let the Backend handle the conversion. Since the Backend can be used by multiple clients, I think the conversion should be done there. Maybe this issue should be moved in Zonemaster-Backend as well.

@ghost ghost added the T-Bug Type: Bug in software or error in test case description label May 31, 2023
@ghost ghost added this to the v2023.2 milestone May 31, 2023
@matsduf
Copy link
Contributor

matsduf commented May 31, 2023

It works to let the domain being tested through GUI. Does GUI do the conversion to A-label? When I try with zmtest it fails.

# zmtest réussir-en.fr
error: method job_create: {
  "code": "-32602",
  "data": [
    {
      "message": "The domain name is IDNA invalid",
      "path": "/domain"
    }
  ],
  "message": "Invalid method parameter(s)."
}

@hannaeko
Copy link
Member

Fixed with 2023.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Bug Type: Bug in software or error in test case description
Projects
None yet
Development

No branches or pull requests

2 participants