Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules names should not be uppercase #437

Closed
hannaeko opened this issue Aug 30, 2023 · 5 comments
Closed

Modules names should not be uppercase #437

hannaeko opened this issue Aug 30, 2023 · 5 comments
Labels
T-Bug Type: Bug in software or error in test case description
Milestone

Comments

@hannaeko
Copy link
Member

The name of the module (as well of test cases for that matter) are uppercase. This cause screen readers to read them like acronyms (C-O-N-S-I-S-T-E-N-C-Y) instead of words (Consistency).
I open the issue here but I think the fix should come from engine, this is were the current strings come from, so that we avoid hacks in GUI to fix that.

@hannaeko hannaeko added the T-Bug Type: Bug in software or error in test case description label Aug 30, 2023
@hannaeko hannaeko added this to the v2023.2 milestone Aug 30, 2023
@matsduf
Copy link
Contributor

matsduf commented Aug 30, 2023

I am not against the change, but I disagree that the fix should come from Engine or GUI. The change should come in the specification. We should define what it should be there, and then implement it in different places. The following document could be a start: https://github.com/zonemaster/zonemaster/blob/master/docs/internal/templates/specifications/tests/TestCaseIdentifierSpecification.md

@hannaeko
Copy link
Member Author

I said Engine because in the current implementation that is where they are coming from.
I guess it would be better if the spec is changed.

@matsduf
Copy link
Contributor

matsduf commented Aug 30, 2023

My point is that we should not change in Engine before we specify the format in the specification. And with specification I do not mean each test case specification, but a specification of how those should be written.

@hannaeko
Copy link
Member Author

Okay I will make a proposal.

@hannaeko
Copy link
Member Author

Fixed with 2023.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Bug Type: Bug in software or error in test case description
Projects
None yet
Development

No branches or pull requests

2 participants