Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project and organization links have inconsistent anchor underlining #5582

Closed
mcbouslog opened this issue Dec 6, 2019 · 3 comments
Closed

Comments

@mcbouslog
Copy link
Contributor

mcbouslog commented Dec 6, 2019

Expected behavior

In the External Project Links section on a project home page and Links section on an organization home page hover or focus on the anchor tags will have consistent underlining.

Current behavior

Icons appear inconsistently underlined (from https://www.zooniverse.org/organizations/meredithspalmer/snapshot-safari):
Screen Shot 2019-12-06 at 10 35 05 AM

If in ExternalLinksBlock.jsx the following is added:

i::before {
  display: inline-block;
}

after the current icon styling it appears to consistently remove an underline, but feels a bit hacky.

@mcbouslog
Copy link
Contributor Author

Referencing #5557

@stale
Copy link

stale bot commented Apr 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 4, 2020
@mcbouslog
Copy link
Contributor Author

Per the organization landing refactor (#5554), this issue is no longer relevant, though edits to organization links section are still needed, as noted in #5592.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant