Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging deploy uses production client ID for auth #199

Closed
mcbouslog opened this issue Dec 4, 2019 · 4 comments · Fixed by #217
Closed

Staging deploy uses production client ID for auth #199

mcbouslog opened this issue Dec 4, 2019 · 4 comments · Fixed by #217
Labels

Comments

@mcbouslog
Copy link
Contributor

mcbouslog commented Dec 4, 2019

Staging deploy uses production client ID for auth instead of staging client ID. I've updated production Doorkeeper so staging deploy allows sign-in (to production, not what desired which would be to staging API) until resolved.

@mcbouslog mcbouslog added the bug label Dec 4, 2019
@mcbouslog
Copy link
Contributor Author

Looked into this a little, still can't figure out why npm stage results in config.js with an envFromShell = production. Console logged process.env.NODE_ENV from webpack.production.config.js and it's staging as would expect, but somewhere between webpack.production.config.js and config.js it's changing from staging to production.

@srallen
Copy link
Contributor

srallen commented Jul 1, 2020

I'm guessing the mode: 'production' in the production config is taking precedence and is setting the environment to production despite the environment plugin a few lines below, so if the staging deploy script is using this, then it will deploy using the production environment? I think we have a similar problem with zooniverse classroom's webpack setup, likely borrowed from each other since they were developed around the same time.

@srallen
Copy link
Contributor

srallen commented Jul 1, 2020

Maybe a separate staging config needs to be defined? Seems like this should work though. Perhaps later webpack versions broke this kind of setup.

@mcbouslog
Copy link
Contributor Author

Noting zooniverse/classroom#174 is indeed same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants