@itsramiel Hey! Thanks for this, but can you reduce the amount of changes to the absolute strict minimum? So just the getter / setter. No code organization change, no event emittters, etc.

@itsramiel Hey! Thanks for this, but can you reduce the amount of changes to the absolute strict minimum? So just the getter / setter. No code organization change, no event emittters, etc.

Sure, but no event emitters would be an incomplete feature. If a user change the language from system settings, the app would not know that without an event.

The radical changes to the RNLocalizationModuleImpl changing it from static to nonstatic methods is to store the context and use it to send events in the sendEvent method.

I can drop these changes if you want, but let me know how you would like to notify changes back to the user.

Sure, but no event emitters would be an incomplete feature. If a user change the language from system settings, the app would not know that without an event.

EDIT: Just got it. This can work without updating the whole code organisation (keeping static methods).

Check how I do on rn-edge-to-edge: https://github.com/zoontek/react-native-edge-to-edge/blob/main/android/src/oldarch/com/zoontek/rnedgetoedge/EdgeToEdgeModule.kt

EDIT: Just got it. This can work without updating the whole code organisation (keeping static methods).

Check how I do on rn-edge-to-edge: zoontek/react-native-edge-to-edge@main/android/src/oldarch/com/zoontek/rnedgetoedge/EdgeToEdgeModule.kt

In the linked code, you are not sending events to js(as far as I can see). I am not sure what you are referring to.

I'll be waiting for your feedback before moving forward with this pr cause I am not sure how you want me to proceed.

I'm not, but you easily call a static method that will do it: Impl.emitEvent(reactContext, …) (in the example, I call EdgeToEdgeModuleImpl.onConfigChange(reactContext))

Yes, in this case since you are creating a broadcastlistener while having access to the context.
In my implementation, users of the library will have to call an onConfigurationChanged from the MainActivity because setting a BroadcastReceiver for ACTION_LOCALE_CHANGED or ACTION_CONFIGURATION_CHANGED is not triggering for Apis < 33, but the onConfigurationChanged on the main activity is called on all Apis

@itsramiel But it also creates the need for an expo plugin, as it must modify the MainActivity.kt file on prebuild. Let me have a closer look at the feature and your WIP when I can find a bit of time.

EDIT: works perfectly on my side, I tried on API 29:

I finally took some time to read the feature documentation and experiment with it. I really dislike the Android API and developer experience—it seems like a mistake to expose it to React Native developers as it currently is.

The goal is to have an in-app language picker that syncs with a device-level language setting (peak UX, thanks Google), so there’s plenty of room for a cleaner, cross-platform API.

But to be honest, I don’t currently have the free time to devote to this, including helping with its design or reviewing it.

Got it.

Thank you for taking the time to check it. Will be closing it for now