diff --git a/api-catalog-ui/frontend/src/actions/catalog-tile-actions.test.jsx b/api-catalog-ui/frontend/src/actions/catalog-tile-actions.test.jsx
index 9510ade875..7e6d91fa37 100644
--- a/api-catalog-ui/frontend/src/actions/catalog-tile-actions.test.jsx
+++ b/api-catalog-ui/frontend/src/actions/catalog-tile-actions.test.jsx
@@ -72,12 +72,4 @@ describe('>>> Catalog tiles actions tests', () => {
expect(actions.fetchNewServiceSuccess([])).toEqual(expectedAction);
});
- it('should create when storing current tile ID', () => {
- const expectedAction = {
- type: constants.STORE_CURRENT_TILEID,
- payload: 'id',
- };
-
- expect(actions.storeCurrentTileId('id')).toEqual(expectedAction);
- });
});
diff --git a/api-catalog-ui/frontend/src/components/Dashboard/Dashboard.test.jsx b/api-catalog-ui/frontend/src/components/Dashboard/Dashboard.test.jsx
index 8daa40758e..dcf268cb82 100644
--- a/api-catalog-ui/frontend/src/components/Dashboard/Dashboard.test.jsx
+++ b/api-catalog-ui/frontend/src/components/Dashboard/Dashboard.test.jsx
@@ -91,24 +91,6 @@ describe('>>> Dashboard component tests', () => {
);
});
- it('should stop epic on unmount', () => {
- const fetchTilesStop = jest.fn();
- const clear = jest.fn();
- const {unmount} = render(
-
- );
- unmount();
- expect(fetchTilesStop).toHaveBeenCalled();
- expect(clear).toHaveBeenCalled();
- });
it('should trigger filterText on handleSearch', async () => {
const filterText = jest.fn();
diff --git a/api-catalog-ui/frontend/src/components/DetailPage/DetailPage.jsx b/api-catalog-ui/frontend/src/components/DetailPage/DetailPage.jsx
index 9647443b02..0f2dfd9877 100644
--- a/api-catalog-ui/frontend/src/components/DetailPage/DetailPage.jsx
+++ b/api-catalog-ui/frontend/src/components/DetailPage/DetailPage.jsx
@@ -44,6 +44,9 @@ function DetailPage({
fetchServiceStop();
setError(formatError(fetchServiceError));
}
+ return () => {
+ fetchServiceStop();
+ }
}, [fetchServiceError,fetchServiceStop,fetchNewService]);
diff --git a/api-catalog-ui/frontend/src/components/DetailPage/DetailPage.test.jsx b/api-catalog-ui/frontend/src/components/DetailPage/DetailPage.test.jsx
index bbfba19128..cfd629c4f5 100644
--- a/api-catalog-ui/frontend/src/components/DetailPage/DetailPage.test.jsx
+++ b/api-catalog-ui/frontend/src/components/DetailPage/DetailPage.test.jsx
@@ -31,6 +31,7 @@ const tile = {
title: 'API Catalog',
description:
'API ML Microservice to locate and display API documentation for API ML discovered microservices',
+ tileDescription: 'Description of the tile',
status: 'UP',
secured: false,
homePageUrl: '/ui/v1/apicatalog',
@@ -49,14 +50,18 @@ jest.mock('react-router', () => {
useNavigate: () => mockNavigate,
};
});
+
+jest.mock("../ServiceTab/ServiceTabContainer", () => ({
+ __esModule: true,
+ default: jest.fn(() => ({})),
+}));
describe('>>> Detailed Page component tests', () => {
afterEach(() => {
jest.clearAllMocks();
});
it('should start epic on mount', () => {
- const fetchTilesStart = jest.fn();
- const fetchNewTiles = jest.fn();
+ const fetchNewService = jest.fn();
renderWithProviders(
@@ -64,32 +69,30 @@ describe('>>> Detailed Page component tests', () => {
tiles={[tile]}
services={tile.services}
currentTileId="apicatalog"
- fetchTilesStart={fetchTilesStart}
- fetchNewTiles={fetchNewTiles}
- fetchTilesStop={jest.fn()}
+ fetchNewService={fetchNewService}
+ fetchServiceStop={jest.fn()}
/>}/>
);
- expect(fetchTilesStart).toHaveBeenCalled();
+ expect(fetchNewService).toHaveBeenCalled();
});
it('should stop epic on unmount', () => {
- const fetchTilesStop = jest.fn();
+ const fetchServiceStop = jest.fn();
const {unmount} = renderWithProviders(
}/>
);
unmount();
- expect(fetchTilesStop).toHaveBeenCalled();
+ expect(fetchServiceStop).toHaveBeenCalled();
});
it('should handle a back button click', () => {
@@ -98,11 +101,10 @@ describe('>>> Detailed Page component tests', () => {
}/>
@@ -119,8 +121,8 @@ describe('>>> Detailed Page component tests', () => {
}/>
@@ -137,49 +139,48 @@ describe('>>> Detailed Page component tests', () => {
}/>
);
- const catalogTile = screen.getByText('API Mediation Layer for z/OS internal API services');
- expect(catalogTile).toBeInTheDocument();
const catalogDescription = screen.getByText('Description of the tile');
expect(catalogDescription).toBeInTheDocument();
});
- it('should stop fetch tiles for 404 response code', () => {
+ it('should stop fetch service for 404 response code', () => {
const isLoading = false;
- const fetchTilesStop = jest.fn();
- const fetchTilesError = {
+ const fetchServiceStop = jest.fn();
+ const fetchServiceError = {
status: 404,
};
- renderWithProviders(
+ const {unmount} = renderWithProviders(
}/>
);
- expect(fetchTilesStop).toHaveBeenCalled();
+
+ expect(fetchServiceStop).toHaveBeenCalled();
});
it('should stop fetch tiles for error message', () => {
const isLoading = false;
- const fetchTilesStop = jest.fn();
- const fetchTilesError = {
+ const fetchServiceStop = jest.fn();
+ const fetchServiceError = {
message: 'some message',
};
renderWithProviders(
@@ -188,43 +189,15 @@ describe('>>> Detailed Page component tests', () => {
}/>
-
-
- );
- expect(fetchTilesStop).toHaveBeenCalled();
- });
-
- it('should clear the selected service, stop and restart fetching if a different tile is selected ', () => {
- const isLoading = false;
- const fetchTilesError = null;
- const fetchTilesStop = jest.fn();
- const fetchTilesStart = jest.fn();
- const clearService = jest.fn();
- const selectedTile = 'apicatalog';
- renderWithProviders(
-
-
- }/>
);
- expect(fetchTilesStop).toHaveBeenCalled();
- expect(clearService).toHaveBeenCalled();
- expect(fetchTilesStart).toHaveBeenCalled();
+ expect(fetchServiceStop).toHaveBeenCalled();
});