Fix skewed timeline for family events #36
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeline for a family gets progressively skewed.
The reason is that the timeline attach points are calculated on the entire vertical span. For a family, they should be calculated on the span only from time 0 (marriage or fallback) to the bottom.
This PR aligns the timeline attach points correctly, see the results below.
For discussion of the code in the PR, I acknowledge that the first two statements after the comments (in the code) could be moved outside the loop, as they do not use or affect anything that changes within the loop. That would very slightly improve performance. However, that is balanced against executing those two statements uselessly for each person timeline, diluting the overall performance issue. My coding style is to keep those two statements together with the other calculations, for better understanding of the code and for potential future maintenance.
@ztlxltl Ready for your review and comments or merging.