Fix connector lines in the timeline #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For events that share the same (approximate) time in the timeline, FTV draws connector lines. Sometimes these connector lines are not correct.
(The timeline below is in months; I adjusted the display on my system for three-digit numbers.)
In addition to the connector lines being wrong, the attach points for events on the vertical timeline are in the wrong places.
I finally found that the bug happens because of de-selected events in the Configuration > Appearance tab. In the example above, census events were de-selected, and there were census events before 1900.
This PR draws the timeline connector lines and the attach points correctly, see the results below.
@ztlxltl Ready for your review and comments or merging.