Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sesameDataGet("KYCG.HM450.Mask.20220123")$recommended has NA value #162

Open
maximilian-leitheiser opened this issue May 9, 2024 · 1 comment

Comments

@maximilian-leitheiser
Copy link

maximilian-leitheiser commented May 9, 2024

Dear SeSAMe developers,

thanks for a great package! I have been using it quite extensively in my research throughout the last year.

I spotted a very minor inaccuracy in the recommended masks for HM450: sesameDataGet("KYCG.HM450.Mask.20220123")$recommended has exactly one NA value (when it probably should have none). All the other values are apparently fine:

mask_list_HM450 = sesameDataGet("KYCG.HM450.Mask.20220123")
mask_rec_HM450 = mask_list_HM450$recommended
mask_rec_HM450_alt = unique(do.call(c, 
                                    mask_list_HM450[sesame:::recommendedMaskNames()[["HM450"]]]))

table(is.na(rec_mask_HM450))
table(is.na(rec_mask_HM450_alt))
setequal(na.omit(rec_mask_HM450), rec_mask_HM450_alt)

As far as I can tell, this has no consequences, since sesame::getMask(platform = "HM450", use_recommended = TRUE) uses the second approach which has no issues. It still confused me for a moment when I came across the discrepency, so I thought a report might still be helpful.

Best,
Max

@zwdzwd
Copy link
Owner

zwdzwd commented May 12, 2024

Thanks for bringing this to our attention. I will fix this in the next EH upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants