Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close storage client after use in indexer rest api #86

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix: close storage client after use in indexer rest api #86

merged 1 commit into from
Feb 21, 2025

Conversation

wanliqun
Copy link
Contributor

@wanliqun wanliqun commented Feb 21, 2025 •
edited by sparkmiw
Loading

This change is Reviewable

@wanliqun wanliqun requested a review from boqiu February 21, 2025 08:11
boqiu
boqiu approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@boqiu boqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wanliqun)

@wanliqun wanliqun merged commit 7c6fb3f into main Feb 21, 2025
3 checks passed
@wanliqun wanliqun deleted the fix-storage-client-not-close branch February 21, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boqiu boqiu boqiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanliqun @boqiu