Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Serializing impersonate enums uses legacy naming conventions #385

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Jan 28, 2025

No description provided.

@0x676e67 0x676e67 changed the title feat(imp): Serializing impersonate enums uses legacy naming conventions feat: Serializing impersonate enums uses legacy naming conventions Jan 28, 2025
@0x676e67 0x676e67 merged commit 0e3ddb0 into main Jan 28, 2025
4 checks passed
@0x676e67 0x676e67 deleted the feat branch January 28, 2025 13:04
@0x676e67
Copy link
Owner Author

This pull request includes significant updates to the Impersonate and ImpersonateOS enums in src/imp/mod.rs, adding detailed documentation and serialization support. Additionally, new tests have been added to ensure the correct serialization and deserialization of these enums.

Enhancements to enums:

  • src/imp/mod.rs: Added comprehensive documentation for the Impersonate enum, detailing the naming conventions and providing examples. The enum now includes multiple browser versions for Chrome, Safari, OkHttp, Edge, and Firefox.
  • src/imp/mod.rs: Introduced the ImpersonateOS enum with documentation, specifying naming conventions and examples. The enum covers various operating systems including Windows, MacOS, Linux, Android, and iOS.

Testing improvements:

  • src/imp/mod.rs: Added a new module with tests for Impersonate and ImpersonateOS enums to verify their serialization and deserialization using serde_json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant