chore: polish code

0xEigenLabs · Aug 11, 2023 · f1a00e8 · f1a00e8
1 parent 8977833
commit f1a00e8
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/plonky/src/field_gl.rs b/plonky/src/field_gl.rs
@@ -475,7 +475,7 @@ impl Fr {
 }
 impl crate::ff::SqrtField for Fr {
     fn legendre(&self) -> crate::ff::LegendreSymbol {
-        let s = self.pow([9223372034707292160u64, 0u64]);
+        let s = self.pow([9223372034707292160u64]);
         if s == Self::zero() {
             crate::ff::LegendreSymbol::Zero
         } else if s == Self::one() {
@@ -490,8 +490,8 @@ impl crate::ff::SqrtField for Fr {
             crate::ff::LegendreSymbol::QuadraticNonResidue => None,
             crate::ff::LegendreSymbol::QuadraticResidue => {
                 let mut c = Fr(ROOT_OF_UNITY);
-                let mut r = self.pow([2147483648u64, 0u64]);
-                let mut t = self.pow([4294967295u64, 0u64]);
+                let mut r = self.pow([2147483648u64]);
+                let mut t = self.pow([4294967295u64]);
                 let mut m = S;
                 while t != Self::one() {
                     let mut i = 1;
@@ -595,19 +595,27 @@ mod tests {
     }
 
     #[test]
-    fn test_inv() {
+    fn gl_check_inv() {
         let mut rng = rand::thread_rng();
         let x = Fr::rand(&mut rng);
         let x_inversed = x.inverse().unwrap();
         assert_eq!(x * x_inversed, Fr::one());
     }
 
     #[test]
-    fn test_neg() {
+    fn gl_check_neg() {
         let mut rng = rand::thread_rng();
         let mut x = Fr::rand(&mut rng);
         let y = x.clone();
         x.negate();
         assert_eq!(x + y, Fr::zero());
     }
+
+    #[test]
+    fn gl_check_sqrt() {
+        let mut rng = rand::thread_rng();
+        let mut x = Fr::rand(&mut rng);
+        let sq_x = x.sqrt().unwrap();
+        assert_eq!(x, sq_x * sq_x);
+    }
 }