Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use errors.New to replace fmt.Errorf with no parameters #131

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ChengenH
Copy link

If you don't need to format the string, recommended to use error.New().

@ChengenH ChengenH requested a review from a team as a code owner April 20, 2024 07:11
@Stefan-Ethernal
Copy link
Collaborator

@ChengenH Thanks for submitting the PR. However, since most of these changes come from the upstream repo: https://github.com/0xPolygonHermez/zkevm-node, it is advisable to raise the PR against it and we are going to fetch it next time we merge the upstream changes to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants