Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ethda protocol #137

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

x-wagmi
Copy link

@x-wagmi x-wagmi commented May 4, 2024

ethda website: https://ethda.io/

@x-wagmi x-wagmi requested a review from a team as a code owner May 4, 2024 15:20
@x-wagmi x-wagmi force-pushed the feat/support-ethda-da-option branch 2 times, most recently from 4b4dd5f to 3da553a Compare May 11, 2024 16:06
@x-wagmi x-wagmi changed the title [WIP] Support ethda da [WIP] Support ethda protocol May 12, 2024
@x-wagmi x-wagmi changed the title [WIP] Support ethda protocol [WIP] Support ETHDA protocol May 12, 2024
@x-wagmi x-wagmi force-pushed the feat/support-ethda-da-option branch 7 times, most recently from c357d0e to 7b1ea94 Compare May 13, 2024 13:33
@vcastellm
Copy link

vcastellm commented May 27, 2024

What is ethda? can you elaborate a full description of the PR?

@arnaubennassar
Copy link
Collaborator

gm! After a team discussion we're reconsidering the idea of adding the different DA protocol integrations directly on this repo. Instead we'd like this code to live on a repo you fully own, and for it to be imported here as an external dependency.

In a nutshell, this PR should only contain the modifications done on:

  • cmd/run.go
  • dataavailability/config.go

Anything else should be handled on a repo of yours. Sorry for the confusion, and the last minute change of mind, but we believe this will be better for everyone

@gavfu
Copy link

gavfu commented May 31, 2024

What is ethda? can you elaborate a full description of the PR?

gm! After a team discussion we're reconsidering the idea of adding the different DA protocol integrations directly on this repo. Instead we'd like this code to live on a repo you fully own, and for it to be imported here as an external dependency.

In a nutshell, this PR should only contain the modifications done on:

  • cmd/run.go
  • dataavailability/config.go

Anything else should be handled on a repo of yours. Sorry for the confusion, and the last minute change of mind, but we believe this will be better for everyone

Hi arnaubennassar & vcastellm, sorry for late reply. EthDA by itself is an Ethereum zk rollup built with Polygon CDK, and is targeted to sever as an Alt-DA solution for other CDK validiums, just as Celestia or Avail does. You could find more info in our website.

This PR is to support starting a CDK validium with EthDA as DA layer (instead of DAC nodes). And thanks for your illustration, we will continue to update the PR following your guidelines.

@x-wagmi x-wagmi force-pushed the feat/support-ethda-da-option branch 5 times, most recently from 8033805 to dc5c32f Compare June 1, 2024 16:09
@x-wagmi
Copy link
Author

x-wagmi commented Jun 1, 2024

@arnaubennassar Hi arnaubennassar, thank you for your reply. We have extracted the EthDA-related code into a separate library. The current changes now only involve cmd/run.go and dataavailability/config.go. Looking forward to your review.

@x-wagmi x-wagmi changed the title [WIP] Support ETHDA protocol Support ETHDA protocol Jun 3, 2024
@x-wagmi x-wagmi changed the title Support ETHDA protocol feat: support ethda protocol Jun 3, 2024
@x-wagmi x-wagmi force-pushed the feat/support-ethda-da-option branch 2 times, most recently from d13357f to 09530a6 Compare June 17, 2024 06:43
@x-wagmi x-wagmi force-pushed the feat/support-ethda-da-option branch from 09530a6 to b2f0a14 Compare June 17, 2024 06:47
@x-wagmi x-wagmi force-pushed the feat/support-ethda-da-option branch from b2f0a14 to f280bf2 Compare August 12, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants