Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample PR to develop #98

Draft
wants to merge 1 commit into
base: release/v0.5.13
Choose a base branch
from
Draft

Conversation

vcastellm
Copy link

@vcastellm vcastellm commented Mar 12, 2024

This contains the base example of the modifications to be done to work with build contraints.

  • We'll need to adapt the build system to use: go build -tags validium cmd/
  • We should not find any conflict when merging from upstream, so no history rewrite for upstream commits, and the PRs should just update cleanly.
  • We need to create a merge script where all files received from upstream will overwrite the corresponding _validium.go files on our repo, so a new PR with these changes should show the diff of what's updated in upstream vs our implementation. This is an example of how it should looks like Update aggregator #99
  • The only requirement is that the zkevm team, allows us to include the //go:build !validium tag on some specific go files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant