Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run polycli with the data race detector enabled in CI #182

Merged
merged 2 commits into from
Jan 4, 2024
Merged

chore: run polycli with the data race detector enabled in CI #182

merged 2 commits into from
Jan 4, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Jan 4, 2024 •
edited
Loading

Description

Run polycli with the data race detector enabled in CI.

Jira / Linear Tickets

Testing

x

@leovct leovct requested a review from a team January 4, 2024 10:49
@praetoriansentry
Copy link
Member

Did you find any performance degradation before and after using -race?

@leovct
Copy link
Member Author

leovct commented Jan 4, 2024

Did you find any performance degradation before and after using -race?

Agree, it's very laggy with polycli monitor and the race detector enabled, especially when monitoring big chains like PoS.

@leovct leovct changed the title chore: build binary with the data race detector enabled chore: run polycli with the data race detector enabled in CI Jan 4, 2024
@leovct leovct merged commit d5fb815 into main Jan 4, 2024
6 checks passed
@leovct leovct deleted the chore/build-polycli-with-data-race-flag branch January 4, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praetoriansentry praetoriansentry praetoriansentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leovct @praetoriansentry