Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: CDK: High level architecture #1563

Merged
merged 32 commits into from
Oct 17, 2024
Merged

DRAFT: CDK: High level architecture #1563

merged 32 commits into from
Oct 17, 2024

Conversation

kmurphypolygon
Copy link
Collaborator

pics and commentary

@kmurphypolygon kmurphypolygon changed the title CDK: High level architecture DRAFT: CDK: High level architecture Oct 3, 2024
Sharonbc01
Sharonbc01 reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@Sharonbc01 Sharonbc01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Katharine maybe we should note the following diagram depicts the full CDK Full Execution Proof (FEP) stack.

@kmurphypolygon kmurphypolygon mentioned this pull request Oct 8, 2024
Closed
joanestebanr
joanestebanr reviewed Oct 8, 2024
View reviewed changes
docs/cdk/architecture/high-level-views.md Outdated Show resolved Hide resolved
docs/cdk/architecture/high-level-views.md Outdated Show resolved Hide resolved
docs/cdk/architecture/high-level-views.md Outdated Show resolved Hide resolved
docs/cdk/architecture/high-level-views.md Outdated Show resolved Hide resolved
@kmurphypolygon kmurphypolygon mentioned this pull request Oct 8, 2024
Closed
@rachit77
Copy link

rachit77 commented Oct 10, 2024 •
edited
Loading

docs/img/cdk/cdk-stack.png

In this diagram, tx-pool-manager is connected to sequence-sender which is incorrect.
sequence-sender should be connected to RPC node instead.

@EmpieichO EmpieichO requested review from EmpieichO and removed request for EmpieichO October 16, 2024 13:12
EmpieichO
EmpieichO approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@EmpieichO EmpieichO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the condition that the comments & suggestions must be addressed.

@kmurphypolygon kmurphypolygon merged commit c333ca7 into main Oct 17, 2024
1 check passed
@kmurphypolygon kmurphypolygon deleted the cdk/high-level branch October 17, 2024 16:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachit77 rachit77 rachit77 left review comments

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal left review comments

@joanestebanr joanestebanr joanestebanr left review comments

@Sharonbc01 Sharonbc01 Sharonbc01 left review comments

@vcastellm vcastellm vcastellm approved these changes

@ToniRamirezM ToniRamirezM ToniRamirezM approved these changes

@EmpieichO EmpieichO EmpieichO approved these changes

@zuiris zuiris Awaiting requested review from zuiris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kmurphypolygon @rachit77 @vcastellm @ToniRamirezM @EmpieichO @Stefan-Ethernal @joanestebanr @Sharonbc01