Use context logger #590
Open
Use context logger #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors/corporates @trunghai95 to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
|
We require contributors/corporates @trunghai95 to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
|
|
Hi team, can someone help to review this? It will take me a lot of time to resolve conflicts if this gets stuck here for too long... |
|
Hi @trunghai95, can you fix the conflicts?? I will add you to cla bot verification once it is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #.
What does this PR do?
Use a more "contextual" logger to make it easy to trace the logs that belong to the same context (e.g. one API request, or one monitorTx cycle). The main idea is to generate a random "traceID" and pass it down through the ctx object.
Reviewers
Main reviewers:
Codeowner reviewers: