Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo in main_generator.cpp and starkRecursiveF.cpp #882

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Typo in main_generator.cpp and starkRecursiveF.cpp #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb46b94
fix typo main_generator.cpp
Pronoss Jan 23, 2025
82a9c90
fix typo main_generator.cpp
Pronoss Jan 23, 2025
2752ef8
fix typo starkRecursiveF.cpp
Pronoss Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main_generator/main_generator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ string generate(const json &rom, uint64_t forkID, string forkNamespace, const st
code += " bool bProcessBatch = (proverRequest.type == prt_processBatch);\n";
code += " bool bUnsignedTransaction = (proverRequest.input.from != \"\") && (proverRequest.input.from != \"0x\");\n\n";

code += " // Unsigned transactions (from!=empty) are intended to be used to \"estimage gas\" (or \"call\")\n";
code += " // Unsigned transactions (from!=empty) are intended to be used to \"estimate gas\" (or \"call\")\n";
code += " // In prover mode, we cannot accept unsigned transactions, since the proof would not meet the PIL constrains\n";
code += " if (bUnsignedTransaction && !bProcessBatch)\n";
code += " {\n";
Expand Down Expand Up @@ -3518,7 +3518,7 @@ code += " #endif\n";
code += " {\n";
code += " proverRequest.result = ZKR_SM_MAIN_HASHP_SIZE_MISMATCH;\n";
code += " zkPC=" + to_string(zkPC) +";\n";
code += " mainExecutor.logError(ctx, \"HashP 2 diferent read sizes in the same position addr=\" + to_string(addr) + \" pos=\" + to_string(pos));\n";
code += " mainExecutor.logError(ctx, \"HashP 2 different read sizes in the same position addr=\" + to_string(addr) + \" pos=\" + to_string(pos));\n";
code += " mainExecutor.pHashDB->cancelBatch(proverRequest.uuid);\n";
code += " return;\n";
code += " }\n";
Expand Down Expand Up @@ -6565,4 +6565,4 @@ void ensureDirectoryExists (const string &fileName)
cout <<"ensureDirectoryExists() system() returned: " << iResult << endl;
exit(-1);
}
}
}
4 changes: 2 additions & 2 deletions src/starkpil/starkRecursiveF/starkRecursiveF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,14 +147,14 @@ void StarkRecursiveF::genProof(FRIProofC12 &proof, Goldilocks::Element publicInp
StarkRecursiveFSteps recurisveFsteps;
StarkRecursiveFSteps *steps = &recurisveFsteps;
// Initialize vars
uint64_t numCommited = starkInfo.nCm1;
uint64_t numCommitted = starkInfo.nCm1;
TranscriptBN128 transcript;
Polinomial evals(N, FIELD_EXTENSION);
Polinomial xDivXSubXi(NExtended, FIELD_EXTENSION);
Polinomial xDivXSubWXi(NExtended, FIELD_EXTENSION);
Polinomial challenges(NUM_CHALLENGES, FIELD_EXTENSION);

CommitPolsStarks cmPols(pAddress, starkInfo.mapDeg.section[eSection::cm1_n], numCommited);
CommitPolsStarks cmPols(pAddress, starkInfo.mapDeg.section[eSection::cm1_n], numCommitted);

RawFr::Element rootC;
RawFr::Element root0;
Expand Down