Suppoort attachments in the protocol #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmidyllic
reviewed
Jan 21, 2025
vmidyllic
reviewed
Jan 21, 2025
src/iden3comm/handlers/auth.ts
Outdated
| @@ -86,6 +88,8 @@ export function createAuthorizationRequestWithMessage( | |||
| created_time: getUnixTimestamp(new Date()), | |||
| expires_time: opts?.expires_time ? getUnixTimestamp(opts.expires_time) : undefined | |||
| }; | |||
|
|
|||
| opts?.attachments && (request.attachments = opts.attachments); | |||
There was a problem hiding this comment.
Looks interesting! However, since attachments are optional, it would be better to assign them directly in the request construction.
attachments: opts?.attachments
vmidyllic
previously approved these changes
Jan 23, 2025
| @@ -64,6 +69,7 @@ export function createProposalRequest( | |||
| created_time: getUnixTimestamp(new Date()), | |||
| expires_time: opts?.expires_time ? getUnixTimestamp(opts.expires_time) : undefined | |||
| }; | |||
| opts.attachments?.length && (request.attachments = opts.attachments); | |||
There was a problem hiding this comment.
same here, better just:
attachments: opts?.attachments
volodymyr-basiuk
previously approved these changes
Jan 29, 2025
Kolezhniuk
dismissed stale reviews from volodymyr-basiuk and vmidyllic
via
a95be40
volodymyr-basiuk
approved these changes
Jan 29, 2025
vmidyllic
reviewed
Jan 30, 2025
| getProtocolMessageTypeByGoalCode(m.body.goal_code) === | ||
| PROTOCOL_MESSAGE_TYPE.PROPOSAL_REQUEST_MESSAGE_TYPE && | ||
| m.to === proposalRequest.to && // issuer | ||
| (!m.body.paymentReference || m.body.paymentReference === proposalRequest.from) // user |
| // credential not found in the wallet, prepare proposal protocol message | ||
| const proposal = await this._params.proposalResolverFn(cred.context, cred.type); | ||
| const proposal = await this._params.proposalResolverFn(cred.context, cred.type, { | ||
| paymentInfo: paymentInfo?.body?.paymentData |
There was a problem hiding this comment.
paymentMessage.body.payments[]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.