feat: add TransactionProver #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisitano
force-pushed
the
frisitano-miden-tx-prover
branch
from
2f5b99d
to
3d6e245
Compare
frisitano
commented
Jul 28, 2023
|
|
||
| impl From<NoteStub> for NoteEnvelope { | ||
| fn from(note_stub: NoteStub) -> Self { | ||
| Self::new(note_stub.hash(), *note_stub.metadata()) |
There was a problem hiding this comment.
NoteStub contains a NoteEnvelope field. Maybe we should use this instead of accessing .has() and .metadata()
There was a problem hiding this comment.
Yep, I think this should work.
frisitano
commented
Jul 28, 2023
miden-tx/src/prover/mod.rs
Outdated
| .map_err(TransactionProverError::ProveTransactionProgramFailed)?; | ||
|
|
||
| // extract transaction outputs and process transaction data | ||
| // extract transaction outputs and process transaction data |
bobbinth
approved these changes
Jul 28, 2023
frisitano
force-pushed
the
frisitano-miden-tx-prover
branch
from
3d6e245
to
f314325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.