-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement get account proof endpoint #556
base: next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! Not a super-deep review from me, but I left a couple of comments inline.
crates/rust-client/src/rpc/mod.rs
Outdated
/// Represents a proof of existence of an account's state at a specific block number. | ||
pub struct AccountProof { | ||
/// Account ID. | ||
account_id: AccountId, | ||
/// Authentication path from the `account_root` of the block header to the account. | ||
merkle_proof: MerklePath, | ||
/// Account hash for the current state. | ||
account_hash: Digest, | ||
/// State headers of public accounts. | ||
state_headers: Option<(AccountHeader, AccountStorageHeader, Option<AccountCode>)>, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be defined in the domain
module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a comment with a possible change, but maybe it's not a worthwhile refactor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
No description provided.