feat: account id validation

0xPolygonMiden · Apr 1, 2024 · 5167ec6 · 5167ec6
1 parent bedcda8
commit 5167ec6
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/rpc/src/server/api.rs b/rpc/src/server/api.rs
@@ -13,7 +13,8 @@ use miden_node_proto::generated::{
     store::api_client as store_client,
 };
 use miden_objects::{
-    transaction::ProvenTransaction, utils::serde::Deserializable, Digest, MIN_PROOF_SECURITY_LEVEL,
+    accounts::AccountId, transaction::ProvenTransaction, utils::serde::Deserializable, Digest,
+    MIN_PROOF_SECURITY_LEVEL,
 };
 use miden_tx::TransactionVerifier;
 use tonic::{
@@ -147,6 +148,15 @@ impl api_server::Api for RpcApi {
     ) -> std::result::Result<Response<GetPublicAccountDetailsResponse>, Status> {
         debug!(target: COMPONENT, request = ?request.get_ref());
 
+        // Validating account using conversion:
+        let _account_id: AccountId = request
+            .get_ref()
+            .account_id
+            .clone()
+            .ok_or(Status::invalid_argument("account_id is missing"))?
+            .try_into()
+            .map_err(|err| Status::invalid_argument(format!("Invalid account id: {err}")))?;
+
         self.store.clone().get_public_account_details(request).await
     }
 }