Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted store fixes #156

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Assorted store fixes #156

merged 1 commit into from
Jan 18, 2024

Conversation

bobbinth
Copy link
Contributor

This PR extracts store-related fixes from #155 which close #152 and also make sure apply_block request succeeds on the store.

igamigo
igamigo approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for extracting the changes. The approach of removing the block path sounds good as well although probably better left for a follow-up PR.

@bobbinth bobbinth merged commit 50ac568 into main Jan 18, 2024
4 checks passed
@bobbinth bobbinth deleted the bobbin-store-fixes branch January 18, 2024 15:59
@bobbinth bobbinth mentioned this pull request Jan 19, 2024
Closed
@igamigo igamigo mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackaugusto hackaugusto hackaugusto left review comments

@igamigo igamigo igamigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chain MMR and note consumption
3 participants
@bobbinth @hackaugusto @igamigo