-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking PR for v0.11.0 release #1472
Draft
bobbinth
wants to merge
104
commits into
main
Choose a base branch
from
next
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+11,557
−4,142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Add warning about `no_std` environment * specify target triples * Document all crates with the `no_std` feature
* refactor: wrap MastFores in Program and Library in Arc * fix: enforce that program entrypoints are procedure roots * refactor: add external nodes to MastForest for re-exports
This reverts commit 72a7093.
Introduce `Emit` instruction
* fix(docs): Fix number of locals and typos * fix(docs): Consistently use `advstack` for the advice stack
This commit introduces the concept of attributes/annotations to Miden Assembly procedures. These can be used to represent interesting/useful bits of metadata associated with specific procedures in three different forms: * Marker attributes, e.g. `@inline`, a name with no associated data * List attributes, e.g. `@inline(always)`, i.e. a parameterized marker; multiple values can be provided as comma-delimited metadata expressions. * Key-value attributes, e.g. `@props(<key> = <value>, ...)`, where `<key>` must be a valid identifier, and `<value>` must be a valid metadata expression. Multiple key-value attributes can be set at once, or you can specify the same key-value attribute multiple times, so long as each instance does not have any keys that conflict with previous instances. Metadata expressions come in three possible types: * bare identifier, e.g. `foo` * quoted string, e.g. `"some text"` * integer value, either decimal or hexadecimal format, e.g. `1` or `0x01` Attributes will provide the foundation for upcoming changes that will rely on being able to attach metadata to procedures. For now, attributes may _only_ be attached to procedure definitions, not re-exports or any other syntactic construct. NOTE: This does not yet act on any attributes, nor store them anywhere when assembling to MAST. For now, they are simply parsed, made available in the AST, and ignored. Future PRs will introduce these as needed. Closes #1434
…-vtable Fix chiplets vtable construction
feat: implement procedure annotation syntax
…able-respan Fix block stack table respan
docs: Document how `CALL` and `SYSCALL` work, and fix block stack table
Co-authored-by: Andrey Khmuro <[email protected]>
* feat(core): Rename `EqHash` -> `MastNodeFingerprint` * chore(core): Document panic in fingerprint computation * chore(core): Add `MpVerify` to comments in fingerprint computation * feat(core): Error instead of panic in fingerprint computation * chore: Add changelog
Fix kernel ROM multiset check
…able Fix block stack table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tracking PR for v0.11.0 release.