Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message for local memory index bounds check #1640

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
+28 −23
Open

fix: improve error message for local memory index bounds check #1640

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
338fedc
Update mem_ops.rs
crStiv Jan 22, 2025
16f5fc3
Update errors.rs
crStiv Jan 23, 2025
00e6d1c
Update mem_ops.rs
crStiv Jan 23, 2025
2496ff3
Update errors.rs
crStiv Jan 30, 2025
f861cb4
Update mem_ops.rs
crStiv Jan 30, 2025
3667fd0
Merge branch 'next' into fix-issue-1619
crStiv Jan 31, 2025
90cf7af
Update mem_ops.rs
crStiv Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion assembly/src/assembler/instruction/mem_ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,17 @@ pub fn local_to_absolute_addr(
}

let max = num_proc_locals - 1;
validate_param(index, 0..=max)?;
if index > max {
return Err(AssemblyError::Other(
Report::msg(
format!(
"invalid local memory index: {} is out of bounds for procedure with {} locals (valid range: 0..{})",
index, num_proc_locals, max
)
)
.into(),
));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually already have the machinery to output very nice error messages (built on top of miette). The desired solution would output an error variant that is similar to InvalidSyscallTarget (in that it takes a SourceSpan and a SourceFile).

}

push_felt(block_builder, -Felt::from(max - index));
block_builder.push_op(FmpAdd);
Expand Down