Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICON REQUEST] Added XAI and Zora network icons. #8

Closed

Conversation

DominicF96
Copy link
Collaborator

@DominicF96 DominicF96 commented May 16, 2024

Hello again!

  • Check the repository first to ensure the icon isn't already available.
  • 24x24 frame icons respecting the icon size guide
  • Provide the name of the token, a link to the official logo (if available), and any other relevant details.
    • XAI Network, included branded and mono variants
    • Sora Network, only included branded variant since mono is just a plain white disk 😬

@DominicF96
Copy link
Collaborator Author

DominicF96 commented May 16, 2024

@0xa3k5 My PRs keep failing, not sure why...

Looks like it's trying to checkout my fork's branch (feature/xai-zora-network-icons), which doesn't exit here and fails..?;

error: src refspec feature/xai-zora-network-icons does not match any
error: failed to push some refs to 'https://github.com/0xa3k5/token-icons'
Error: Process completed with exit code 1.

I suspect it's on line 100 of ./github/workflows/icon-add.yml.

99          fi
100         git push origin ${GITHUB_HEAD_REF:-${GITHUB_REF}} // Here

@0xa3k5
Copy link
Owner

0xa3k5 commented May 16, 2024

hey @DominicF96 thank you so much for your contributions!

your PR made me realize a small issue regarding how we are matching the network names and generating the metadata, I added a fix for it.

regarding why the checks are failing: I'm pretty new to github actions and I'm sure I misconfigured it. If you know of a solutions, a PR would be awesome, if not I'll try to fix it after I'm done with the improvements I've working on the next branch.

I just invited you to the repository as a collaborator as a workaround for now.

@0xa3k5
Copy link
Owner

0xa3k5 commented May 16, 2024

@DominicF96 can you review the conflict please, I'll publish a new release after the conflict is resolved and the pr is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants