Clawback metadata #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Agusx1211
commented
May 31, 2024
Agusx1211
commented
- Use snake case for attributes
- Add human readable duration values
Agusx1211
force-pushed
the
clawback-metadata
branch
from
0dc9324 to
48d76fa
Compare
| @@ -194,4 +197,18 @@ contract ClawbackMetadata is IMetadataProvider, IERC165 { | |||
| } | |||
| return false; | |||
| } | |||
|
|
|||
| function _formatUnlocksIn(uint256 lockedAt, uint256 duration) internal view returns (string memory) { | |||
There was a problem hiding this comment.
I intentionally chose not to add this as most platforms cache the metadata. Thought it would be out of date and confusing for non-native/tech people.
Happy to include if you disagree.
There was a problem hiding this comment.
Middle ground would be to reduce the granularity to days and exclude hours etc.
There was a problem hiding this comment.
I don't think it is a big issue, we can update it later if it gives us trouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.