Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve long image name overflow problem #81

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

yigiterdev
Copy link
Contributor

@yigiterdev yigiterdev commented Dec 18, 2023

Screenshot 2023-12-18 at 15 27 14

@corbanbrook
Copy link
Collaborator

Ok, so this commit would allow long file names to expand the Input to fit the entire name.

Im questioning if its much of an issue if i cannot read the full filename of an input. Seems like we can just place an ellipsis if the name exceeds the bonds.

@yigiterdev
Copy link
Contributor Author

Input width is different in most of the areas. How can we measure max-width of the file name? Do you have any idea? @corbanbrook

@corbanbrook
Copy link
Collaborator

I am of the opinion we should just use text-overflow: ellipsis and not let the height if the input expand.

@tolgahan-arikan
Copy link
Collaborator

As a user, I would prefer seeing the whole name, especially to be able to see the file extension.
But it's not a huge deal either...

@corbanbrook
Copy link
Collaborator

Screenshot 2023-12-18 at 2 10 09 PM

Users can also hover (in desktop) to get the tooltip of the full filename

@corbanbrook
Copy link
Collaborator

Screenshot 2023-12-18 at 2 41 56 PM

A better example with some changes to allow ellipsis.

My main concern about having this field auto expand in height is that it will un intendedly break alignment with other UI elements.

@yigiterdev
Copy link
Contributor Author

I'm okey with ellipsis. Thank you so much 🫶🏻 Can you push your updates to this PR? @corbanbrook

@corbanbrook corbanbrook merged commit 8c45a21 into master Dec 18, 2023
1 check passed
@corbanbrook corbanbrook deleted the solve-long-image-name-problem branch December 18, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants