Hash.Bytes() fix #147
Closed
Hash.Bytes() fix #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `Hash.Bytes()` should return the entire byte slice instead of the truncated version from `Hash.Hash().Bytes()`
marino39
requested changes
Jul 24, 2024
| @@ -124,20 +124,20 @@ func (h Hash) IsValidTxnHash() bool { | |||
| return true | |||
| } | |||
|
|
|||
| func (h Hash) Bytes() []byte { | |||
There was a problem hiding this comment.
I'm not able to check it right now as I'm on holidays, however this may make indexer and other services using this new version of library not backward compatible.
I wouldn't change that. It's risky.
There was a problem hiding this comment.
I agree. I prefer not to make this change.. is it required..?
There was a problem hiding this comment.
I propose let’s keep this PR as a draft and we can reconsider it in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
Hash.Bytes()should return the entire byte slice instead of the truncated version fromHash.Hash().Bytes()