Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching out old indexer api #196

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Switching out old indexer api #196

merged 3 commits into from
Jan 14, 2025

Conversation

andrewlee348
Copy link
Contributor

No description provided.

@andrewlee348 andrewlee348 marked this pull request as ready for review November 18, 2024 23:23
@andrewlee348
Copy link
Contributor Author

andrewlee348 commented Nov 18, 2024 •
edited
Loading

I'll remove the //ATTENTION: comments later as they might be useful to change things before merge

@taylanpince
Copy link
Contributor

@andrewlee348 lgtm, we'll wait for @corbanbrook and @tolgahan-arikan 's reviews

Please remove the ATTENTION lines now, thank you

@andrewlee348 andrewlee348 requested a review from a team as a code owner December 16, 2024 20:58
@andrewlee348 andrewlee348 force-pushed the 3663-switch-out-old-indexer-endpoints branch from 43f9496 to 9f833dd Compare January 13, 2025 14:55
corbanbrook
corbanbrook requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@corbanbrook corbanbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good overall but one thing to note is that the data hooks are publically exposed by the library. So this introduces breaking changes.

I think it would be good if we kept the hooks args the same as previously if possible.

@andrewlee348 andrewlee348 force-pushed the 3663-switch-out-old-indexer-endpoints branch from 9f833dd to f4c4d69 Compare January 14, 2025 19:15
@andrewlee348 andrewlee348 merged commit 18ea4a9 into master Jan 14, 2025
1 check passed
@andrewlee348 andrewlee348 deleted the 3663-switch-out-old-indexer-endpoints branch January 14, 2025 22:27
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
@andrewlee348
Build: (18ea4a9) Switching out old indexer api (#196)
d401692 
* Added new hooks for new indexer endpoints

* exposed hooks and replaced internal calls to new hooks

* Replaced all deprecated calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corbanbrook corbanbrook corbanbrook approved these changes

@taylanpince taylanpince Awaiting requested review from taylanpince

@bunnybones1 bunnybones1 Awaiting requested review from bunnybones1

@SamueleA SamueleA Awaiting requested review from SamueleA

@tolgahan-arikan tolgahan-arikan Awaiting requested review from tolgahan-arikan

@0xsequence-bot 0xsequence-bot Awaiting requested review from 0xsequence-bot 0xsequence-bot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewlee348 @taylanpince @corbanbrook