Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate ABI function name and signatures #177

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

BellringerQuinn
Copy link
Contributor

so that we throw an argument exception and make it easier to diagnose a common issue where users were providing an ABI in the wrong format

…t exception and make it easier to diagnose a common issue where users were providing an ABI in the wrong format
@pkieltyka
Copy link
Member

pkieltyka commented Sep 26, 2024

nice work.. I think even better.. just port the code https://github.com/0xsequence/ethkit/blob/master/ethcoder/events_parser.go#L38

to C# .. as you will see, its just string manipulation.

I propose name the function, ParseABISelector instead of ParseEventDef.. I think that "selector" is a better name for this, as its for functions and events.

then, you can handle any input and it will just work, it wont error for users :)

its 350 LOC

@BellringerQuinn BellringerQuinn requested review from a team as code owners November 4, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants