Feature/playfabvalidateinput&lockbutton #273
Open
+415
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a new account and logging in do some form of validation, whether via federation or a new session. At least for now, let's only log a warning when federation fails due to failed login (much like we do when a basic login fails) - an error log during a test causes the test to fail
Was only locking one button, now both follow the same logic. Also was unlocking for empty newaccount email and new account password which didnt make sense
BellringerQuinn
previously approved these changes
Jan 20, 2025
caballoninja
dismissed
BellringerQuinn’s stale review
The merge-base changed after approval.
BellringerQuinn
previously approved these changes
Jan 21, 2025
caballoninja
dismissed
BellringerQuinn’s stale review
The merge-base changed after approval.
BellringerQuinn
previously approved these changes
Jan 24, 2025
caballoninja
dismissed
BellringerQuinn’s stale review
The merge-base changed after approval.
andygruening
previously approved these changes
Jan 31, 2025
caballoninja
dismissed
andygruening’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs Checklist
Please ensure you have addressed documentation updates if needed as part of this PR: