Skip to content

Commit

Permalink
Update todo
Browse files Browse the repository at this point in the history
  • Loading branch information
tolgahan-arikan committed Nov 8, 2023
1 parent 668cc78 commit 8f782b7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/auth/src/services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export class Services {
ethAuth.chainId = chainId.toNumber()

// TODO: Modify ETHAuth so it can take a provider instead of a url
// QUESTION/TODO: should we make projectAccessKey non-optional in services so we can be sure this provider will have proper rpcUrl?
// TODO: Make sure 'network.rpcUrl' has the proper projectAccessKey
ethAuth.provider = new ethers.providers.StaticJsonRpcProvider(getDefaultConnectionInfo(network.rpcUrl), {
name: '',
chainId: chainId.toNumber()
Expand Down Expand Up @@ -287,7 +287,7 @@ export class Services {
if (!network) throw Error('No network found')
ethAuth.chainId = chainId.toNumber()
// TODO: Modify ETHAuth so it can take a provider instead of a url
// QUESTION/TODO: should we make projectAccessKey non-optional in services so we can be sure this provider will have proper rpcUrl?
// TODO: Make sure 'network.rpcUrl' has the proper projectAccessKey
ethAuth.provider = new ethers.providers.StaticJsonRpcProvider(getDefaultConnectionInfo(network.rpcUrl), {
name: '',
chainId: chainId.toNumber()
Expand Down

0 comments on commit 8f782b7

Please sign in to comment.