Rename buildEIP6492Signature

0xsequence · Dec 5, 2024 · e8cbccd · e8cbccd
1 parent fc97408
commit e8cbccd
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 17 deletions.
diff --git a/packages/passkeys/src/index.ts b/packages/passkeys/src/index.ts
@@ -258,19 +258,7 @@ export class SequencePasskeySigner implements signers.SapientSigner {
     return signatureBytes
   }
 
-  async buildValidationSignature(signatureBytes: string): Promise<string | undefined> {
-    console.log('passkey buildValidationSignature', signatureBytes)
-    try {
-      if (await this.isDeployed()) {
-        return undefined
-      }
-    } catch (e) {
-      // Ignore. Assume not deployed
-    }
-    return this.buildEIP6492Signature(signatureBytes)
-  }
-
-  private async buildEIP6492Signature(signature: string): Promise<string> {
+  async buildEIP6492Signature(signature: string): Promise<string> {
     const deployTransactions = await this.buildDeployTransaction()
     if (!deployTransactions || deployTransactions?.transactions.length === 0) {
       throw new Error('Cannot build EIP-6492 signature without deploy transaction')

diff --git a/packages/signhub/src/orchestrator.ts b/packages/signhub/src/orchestrator.ts
@@ -186,9 +186,9 @@ export class Orchestrator {
               .then(async signature => {
                 const suffix = s.suffix()
                 let validationSignature
-                if (s.buildValidationSignature) {
+                if (s.buildEIP6492Signature) {
                   try {
-                    validationSignature = await s.buildValidationSignature(signature)
+                    validationSignature = await s.buildEIP6492Signature(signature)
                   } catch (e) {
                     // Log and ignore
                     console.warn(`signer ${saddr} failed to build validation signature: ${e}`)

diff --git a/packages/signhub/src/signers/signer.ts b/packages/signhub/src/signers/signer.ts
@@ -28,7 +28,7 @@ export interface SapientSigner {
   /**
    * Build a validation signature for an undeployed contract signer.
    */
-  buildValidationSignature?(signatureBytes: ethers.BytesLike): Promise<ethers.BytesLike | undefined>;
+  buildEIP6492Signature?(signature: ethers.BytesLike): Promise<ethers.BytesLike | undefined>;
 
   /**
    * Notify the signer of a status change.

diff --git a/packages/signhub/tests/orchestrator.spec.ts b/packages/signhub/tests/orchestrator.spec.ts
@@ -100,7 +100,7 @@ describe('Orchestrator', () => {
         suffix(): ethers.BytesLike {
           return new Uint8Array([2])
         }
-        async buildValidationSignature(signature: string) {
+        async buildEIP6492Signature(signature: string) {
           return signature + 'validation'
         }
       }