Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Immutable types #70

Merged
merged 3 commits into from
Jun 13, 2024
Merged

chore: add Immutable types #70

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72525ff
chore: add Immutable types
corysquid Jun 12, 2024
58790a7
chore: use IMMUTABLE_ZKEVM type
corysquid Jun 13, 2024
091122b
chore: increase package version
corysquid Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/chains/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ export enum ChainName {
FANTOM = "Fantom",
FILECOIN = "filecoin",
FILECOIN2 = "filecoin-2", //testnet
IMMUTABLE_ZKEVM = "immutable",
KAVA = "kava",
MANTLE = "mantle",
MOONBEAM = "Moonbeam",
Expand Down Expand Up @@ -167,6 +168,7 @@ export enum NetworkIdentifier {
CELO = "celo",
FANTOM = "fantom",
FILECOIN = "filecoin",
IMMUTABLE = "immutable",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not IMMUTABLE_ZKEVM here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine if just Immutable, but there will likely be other Immutable chains to add in the future. They also have ImmutableX in prod currently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to IMMUTABLE_ZKEVM, makes sense to keep that consistent

KAVA = "kava",
MANTLE = "mantle",
MOONBEAM = "moonbeam",
Expand Down
Loading